Skip to content

Conversation

@nupurvavhal
Copy link

Describe your change:

Added type hints to count_inversions_bf, count_inversions_recursive, and helper functions for better code clarity and IDE support. Tested locally with python3 divide_and_conquer/inversions.py.

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

Copilot AI review requested due to automatic review settings February 10, 2026 10:58
@algorithms-keeper algorithms-keeper bot added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed labels Feb 10, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds Python type hints to the inversion-counting implementation in divide_and_conquer/inversions.py to improve readability and editor/static-analysis support.

Changes:

  • Annotated count_inversions_bf() parameter/return types.
  • Annotated count_inversions_recursive() and _count_cross_inversions() parameter/return types.
  • Added a return annotation to main().

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@algorithms-keeper algorithms-keeper bot added the tests are failing Do not merge until tests pass label Feb 10, 2026
@nupurvavhal nupurvavhal force-pushed the fix-type-hints-inversions branch from fd44b0a to b4a6c84 Compare February 10, 2026 11:14
@algorithms-keeper algorithms-keeper bot removed the tests are failing Do not merge until tests pass label Feb 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants