Fix Select widget border not rendering due to BLANK name collision #6359
+2
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Widget.BLANK(aClassVar[bool]defaulting toFalse) was added in v7.1.0 to allow widgets to opt into blank renderingSelect.BLANKis a pre-existingNoSelectionsentinel object used to represent "no value selected"render_lineandrender_lineswere optimized to checkif self.BLANK:and skip normal rendering — butNoSelection()is truthy, soSelectinadvertently enters the blank rendering path, causing its border (and all visual chrome) to disappearif self.BLANK is True:to match only the booleanTrue, not arbitrary truthy objectsReproduction
Expected: Select has a heavy border
Actual (7.2.0+): Select renders with no border
Test plan
Widget.BLANK = Truestill produces blank rendering for widgets that use it