fix: horizontal scroll, Home/End keys, and line operations in SQL editor#500
Merged
fix: horizontal scroll, Home/End keys, and line operations in SQL editor#500
Conversation
4500f35 to
b4e7fce
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root Causes
Horizontal scroll: Variable shadowing bug in CodeEditTextView
layoutLine()—var maxFoundLineWidth = maxFoundLineWidthshadowed the inout param, somaxLineWidthnever updated. Also patchedstyleTextView()to respectwrapLines.Home/End: AppKit maps Home/End to
scrollToBeginningOfDocument:/scrollToEndOfDocument:which only scroll without moving cursor. CodeEditTextView didn't override these.Line operations:
moveLinesUp()/moveLinesDown()existed but were never wired to key bindings. Also had bugs with trailing-newline handling and UTF-16 string splitting.Changes
maxFoundLineWidthshadowing, add Home/End handling inkeyDown, addmoveToBeginningOfLine/moveToEndOfLine/centerSelectionInVisibleAreaoverridesstyleTextView()/styleScrollView()for horizontal scroll, wire Cmd+Shift+D/K and Option+Up/Down inhandleCommand, addduplicateLine()/deleteLine(), rewritemoveLinesUp()/moveLinesDown()with correct newline and UTF-16 handlingTest plan