Skip to content

fix: resolve sidebar CancellationError and truncate long toolbar version#492

Merged
datlechin merged 1 commit intomainfrom
fix/oracle-cancellation-toolbar-truncation
Mar 28, 2026
Merged

fix: resolve sidebar CancellationError and truncate long toolbar version#492
datlechin merged 1 commit intomainfrom
fix/oracle-cancellation-toolbar-truncation

Conversation

@datlechin
Copy link
Copy Markdown
Collaborator

Summary

  • Sidebar showed "Query execution failed: CancellationError()" on first Oracle connection due to a race condition between connection establishment and table loading
  • Long database version strings (e.g., Oracle's full banner) overflowed the toolbar

Changes

  • OracleConnection.swift: Re-throw CancellationError instead of wrapping it as an OracleError with a user-visible message
  • SidebarViewModel.swift: Handle CancellationError silently (not a user-facing error); cancel previous load task before starting a new one
  • ConnectionStatusView.swift: Add lineLimit(1), truncationMode(.middle), and frame(maxWidth: 280) to the version text. Full string shown in tooltip on hover.

Test plan

  • Connect to Oracle 18c XE. Sidebar should not show CancellationError on first connect
  • Oracle toolbar version truncates with "..." in the middle, full text in tooltip
  • MySQL/PostgreSQL toolbar version unchanged (short enough to fit)
  • Sidebar refresh still works

@datlechin datlechin merged commit df6d004 into main Mar 28, 2026
2 checks passed
@datlechin datlechin deleted the fix/oracle-cancellation-toolbar-truncation branch March 28, 2026 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant