Conversation
|
Visit the preview URL for this PR (updated for commit 2f2a44a): https://sunnytechwebsite--pr58-feat-rainytheme-miyi7ei8.web.app (expires Tue, 07 Apr 2026 10:48:36 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: b96ac7ab85879442bb94dc448b41aeca0f34d16c |
Razano26
force-pushed
the
feat/rainyTheme
branch
from
5314ea7 to
0c17e40
Compare
|
@copilot do you think you could add a shader to make the page text diseappear with gravity as real ink does with water? |
|
@HugoGresse I've opened a new pull request, #59, to work on those changes. Once the pull request is ready, I'll request review from you. |
Add rainy logo and hero background images. Update Hero to include a data-rainy-src for background swapping. Inject a client script in Layout that, when the date is March 18, overrides theme colors, replaces text/logo/background assets, draws frogs on the 404 canvas, and adds an animated rain overlay and drops. Signed-off-by: Louis Labeyrie <labeyrielouis@gmail.com>
Razano26
force-pushed
the
feat/rainyTheme
branch
from
0c17e40 to
6c76a54
Compare
There was a problem hiding this comment.
Pull request overview
Cette PR ajoute un thème “Rainy Tech” appliqué côté client à une date précise, avec remplacement d’assets (fond du hero, logos) et un habillage visuel (overlay de pluie), afin de transformer temporairement l’apparence et certains libellés du site.
Changes:
- Ajout d’un script global dans le layout pour appliquer le thème “Rainy Tech” (CSS variables, remplacements de texte, swap d’images/logos, overlay animé, remplacement de l’art 404).
- Ajout d’un asset de fond alternatif (
home_rain.png) et exposition de son URL viadata-rainy-srcsur le hero.
Reviewed changes
Copilot reviewed 2 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| src/layouts/Layout.astro | Ajoute la logique client d’application du thème (swap d’images/logos, overlay, modifications DOM/canvas). |
| src/components/home/Hero.astro | Ajoute l’import de l’image de fond “rain” et la rend accessible via un data-* pour le swap côté client. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
HugoGresse
left a comment
HugoGresse
left a comment
There was a problem hiding this comment.
Il faudrait prendre en compte les retours de Copilot mais surtout faire un JS dans une fichier dédié et pas directement dans le layout non ?
- Extract inline JS from Layout.astro into dedicated src/scripts/rainy-theme.ts - Convert home_rain.png (3.1MB) to home_rain.webp (280KB) - Add id to injected <style> to prevent duplicate style injection - Remove srcset/sizes on hero img when swapping to rain background - Skip rain overlay animation when prefers-reduced-motion is enabled Signed-off-by: Louis Labeyrie <labeyrielouis@gmail.com>
Razano26
force-pushed
the
feat/rainyTheme
branch
from
0f5b9b2 to
2f2a44a
Compare
No description provided.