refactor: modifying _update_from_checkpoint signature#186
Open
refactor: modifying _update_from_checkpoint signature#186
Conversation
jeandut
commented
Jan 19, 2024
cdb467e to
a56ce18
Compare
Signed-off-by: jeandut <jean.du-terrail@owkin.com>
9aafcd8 to
78224dc
Compare
SdgJlbl
reviewed
Jan 23, 2024
Contributor
SdgJlbl
left a comment
There was a problem hiding this comment.
Thanks a lot for your PR.
I understand the context of the change, and I agree that it is best to separate the I/O (loading the checkpoint) and the update part. Nevertheless, the method _update_from_checkpoint was idempotent (i.e. you can apply it several times in a row and get the same results as if you apply it once), and it's not the case anymore after your change, because of the side effect on checkpoint. It would be safer to keep _update_from_checkpoint idempotent, either by reading from checkpoint but not popping values from it, or by passing a copy to the function.
Author
|
Okay will copy checkpoint in the function however striving for functional purity is a bit of an unattainable ideal. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
No related issue
Summary
Notes
This PR introduces a change in the signature of the algorithm's
update_from_checkpointfunction in order to ease its use in complex pipelines.As of before this PR if you had a checkpoint (a dict from say a call to get_state_to_save) it was impossible to load it ...
Now workflows can use patterns like:
Please check if the PR fulfills these requirements