Introduce bq util to get latest table name given prefix.#516
Open
Introduce bq util to get latest table name given prefix.#516
Conversation
svij-sc
requested review from
kmontemayor2-sc,
mkolodner-sc,
nshah-sc,
xgao4-sc,
yliu2-sc and
zfan3-sc
as code owners
Collaborator
Author
|
/unit_test |
Contributor
GiGL Automation@ 19:37:29UTC : 🔄 @ 19:43:51UTC : ❌ Workflow failed. |
Contributor
GiGL Automation@ 19:37:30UTC : 🔄 @ 19:45:04UTC : ✅ Workflow completed successfully. |
Collaborator
|
Also let's fix the unit tests? |
kmontemayor2-sc
approved these changes
Feb 26, 2026
Comment on lines
+294
to
+297
| *table_partition_suffix*. All supported GCP partition suffixes (``YYYY``, | ||
| ``YYYYMM``, ``YYYYMMDD``, ``YYYYMMDDHH``, integer ranges) are | ||
| lexicographically sortable, so the latest table is the | ||
| lexicographic maximum. |
Collaborator
There was a problem hiding this comment.
is there some GCP docs we can link to here?
gigl/src/common/utils/bq.py
Outdated
| bq_dataset_path=bq_dataset_path, table_match_string=table_prefix | ||
| ) | ||
| suffix_len = len(table_partition_suffix) | ||
| candidates = [] |
Collaborator
There was a problem hiding this comment.
nit. type empty collections
Suggested change
| candidates = [] | |
| candidates: list[str]= [] |
gigl/src/common/utils/bq.py
Outdated
Comment on lines
+325
to
+338
| for table_name in matched_full_table_paths: | ||
| assert ( | ||
| len(table_name) == len(bq_table_path_prefix) + suffix_len | ||
| ), f"Table name {table_name} does not end with a suffix of format {table_partition_suffix}" | ||
| if cap_date is None or table_name[-suffix_len:] <= cap_date: | ||
| candidates.append(table_name) | ||
| if not candidates: | ||
| raise ValueError( | ||
| f"No tables found with prefix {bq_table_path_prefix} and cap date {cap_date}" | ||
| ) | ||
| candidates.sort() | ||
| return candidates[ | ||
| -1 | ||
| ] # Get the latest table @ last index (since sorted Ascending) |
Collaborator
There was a problem hiding this comment.
double nit. we don't need to sort we can just have a latest_table we update as we go through validating the table.
yliu2-sc
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope of work done
Introducing functionality to get latest table name given prefix for a datetime suffixed table.
We are duplicating this functionality in downstream use cases - figured i'd intro a utility.