Add George Pet sell price tooltip#2239
Open
WilliamTTran wants to merge 1 commit intoSkyblockerMod:masterfrom
Open
Add George Pet sell price tooltip#2239WilliamTTran wants to merge 1 commit intoSkyblockerMod:masterfrom
WilliamTTran wants to merge 1 commit intoSkyblockerMod:masterfrom
Conversation
Alex33856
reviewed
Mar 16, 2026
src/main/java/de/hysky/skyblocker/skyblock/item/tooltip/adders/GeorgePriceTooltip.java
Show resolved
Hide resolved
src/main/java/de/hysky/skyblocker/skyblock/item/tooltip/adders/GeorgePriceTooltip.java
Outdated
Show resolved
Hide resolved
WilliamTTran
force-pushed
the
george-sell-price
branch
from
4bbadce to
afe1c97
Compare
Alex33856
reviewed
Mar 19, 2026
Contributor
There was a problem hiding this comment.
This file can be reverted
| * | ||
| * <p>The method early-returns without adding a line if: | ||
| * <ul> | ||
| * <li>the item is not a pet (Skyblock API ID does not start with {@code LVL_1_})</li> |
Contributor
There was a problem hiding this comment.
Remove the text in parenthesis since it is no longer accurate
| * {@link TooltipInfoType#GEORGE}. Keys in that dataset follow the format | ||
| * {@code RARITY_PETNAME} (e.g. {@code EPIC_SQUID}, {@code LEGENDARY_WOLF}). | ||
| * | ||
| * <p>Pet item stacks expose their Skyblock API ID via {@code getSkyblockApiId()} in the format |
Contributor
There was a problem hiding this comment.
This paragraph can also be removed for the same reason
Alex33856
requested changes
Mar 19, 2026
Contributor
Alex33856
left a comment
Alex33856
left a comment
There was a problem hiding this comment.
(clicked wrong button earlier 💀)
LifeIsAParadox
added
changes requested
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#2228
Adds a tooltip line showing the George NPC sell price for pet items because I've seen people selling a legendary megalodon on AH for 2.4 million
Changes:
Testing:
code/documentation assisted by claude