Skip to content

Added time input calculator#2189

Open
NamelessJu wants to merge 5 commits intoSkyblockerMod:masterfrom
NamelessJu:master
Open

Added time input calculator#2189
NamelessJu wants to merge 5 commits intoSkyblockerMod:masterfrom
NamelessJu:master

Conversation

@NamelessJu
Copy link

Currently the AH duration input uses the regular input calculator, which shows errors on valid time inputs such as "2d".
This time calculator fixes this by displaying the entered amount of time instead:

Screenshot 2026-03-02 001719
(Correctly uses the time unit selected in the AH menu by default, so either hours or minutes)

It also allows for inputting multiple time units along with comma values:

Screenshot 2026-03-02 001514

Also converts whatever is entered into a cleaner format:

Screenshot 2026-03-02 001554
(I did a quick test and the auction house actually allows and correctly uses values like this, even though it only shows the highest unit entered in the auction creation screen)

+ I added config values for this new calculator:

  • enabled (default: true)
  • close sign on enter (default: true)

I also added a German translation for this, but I am not sure how exactly how you handle translations so I made it a separate commit to disconnect it from the core feature implementation

@LifeIsAParadox LifeIsAParadox added the reviews needed This PR needs reviews label Mar 2, 2026
@NamelessJu
Copy link
Author

My bad, I only now found out about the checkstyle gradle tasks. Should be fine now (hopefully)

@NamelessJu
Copy link
Author

And we try again (sorry), I ran a full successful build on my end now (don't know why I didn't do this earlier)

@AzureAaron AzureAaron added the new feature This issue or PR is a new feature label Mar 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new feature This issue or PR is a new feature reviews needed This PR needs reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants