Skip to content

Acquire semian resource for each retry in Active Record adapters#1034

Draft
gmcgibbon wants to merge 2 commits intomainfrom
acquire_on_individual_retries
Draft

Acquire semian resource for each retry in Active Record adapters#1034
gmcgibbon wants to merge 2 commits intomainfrom
acquire_on_individual_retries

Conversation

@gmcgibbon
Copy link
Member

Previously, Active Record adapters would retry queries within the same acquisition attempt. Now, we wrap individual executions to ensure each retry is counted as one acquisition request.

@gmcgibbon gmcgibbon force-pushed the acquire_on_individual_retries branch from 34f3a64 to aa07544 Compare March 5, 2026 23:45
@gmcgibbon gmcgibbon marked this pull request as draft March 6, 2026 08:46
Previously, Active Record adapters would retry queries within the
same acquisition attempt. Now, we wrap individual executions to
ensure each retry is counted as one acquisition request.
@gmcgibbon gmcgibbon force-pushed the acquire_on_individual_retries branch from aa07544 to 7466135 Compare March 6, 2026 08:48
@gmcgibbon
Copy link
Member Author

Making retries happen at the perform_query level makes it so we need to translate exceptions early, which is a little annoying. There might be other tradeoffs too. I've put this into draft while I dig deeper.

Makes the dev container build properly.
@gmcgibbon gmcgibbon force-pushed the acquire_on_individual_retries branch from 7498cd9 to cc2724c Compare March 6, 2026 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant