Skip to content

Simplify initializations in GMGPolar::setup#187

Merged
julianlitz merged 1 commit intomainfrom
litz_setup_init
Feb 27, 2026
Merged

Simplify initializations in GMGPolar::setup#187
julianlitz merged 1 commit intomainfrom
litz_setup_init

Conversation

@julianlitz
Copy link
Collaborator

Refactors the operator initialization section of GMGPolar::setup() to improve clarity and separation of concerns.
Previously, a single loop over all levels used if/else branching to handle level-specific logic (finest, coarsest, intermediate), mixing smoother, direct solver, and residual initialization in one place. This made the control flow harder to follow.

Merge Request - GuideLine Checklist

Guideline to check code before resolve WIP and approval, respectively.
As many checkboxes as possible should be ticked.

Checks by code author:

Always to be checked:

  • There is at least one issue associated with the pull request.
  • New code adheres with the coding guidelines
  • No large data files have been added to the repository. Maximum size for files should be of the order of KB not MB. In particular avoid adding of pdf, word, or other files that cannot be change-tracked correctly by git.

If functions were changed or functionality was added:

  • Tests for new functionality has been added
  • A local test was succesful

If new functionality was added:

  • There is appropriate documentation of your work. (use doxygen style comments)

If new third party software is used:

  • Did you pay attention to its license? Please remember to add it to the wiki after successful merging.

If new mathematical methods or epidemiological terms are used:

  • Are new methods referenced? Did you provide further documentation?

Checks by code reviewer(s):

  • Is the code clean of development artifacts e.g., unnecessary comments, prints, ...
  • The ticket goals for each associated issue are reached or problems are clearly addressed (i.e., a new issue was introduced).
  • There are appropriate unit tests and they pass.
  • The git history is clean and linearized for the merge request. All reviewers should squash commits and write a simple and meaningful commit message.
  • Coverage report for new code is acceptable.
  • No large data files have been added to the repository. Maximum size for files should be of the order of KB not MB. In particular avoid adding of pdf, word, or other files that cannot be change-tracked correctly by git.

@codecov
Copy link

codecov bot commented Feb 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.28%. Comparing base (a5f97e6) to head (36b4014).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #187      +/-   ##
==========================================
+ Coverage   95.21%   95.28%   +0.06%     
==========================================
  Files          94       94              
  Lines        9322     9306      -16     
==========================================
- Hits         8876     8867       -9     
+ Misses        446      439       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@julianlitz julianlitz merged commit aac9b10 into main Feb 27, 2026
8 checks passed
@julianlitz julianlitz deleted the litz_setup_init branch February 27, 2026 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants