Add applySystemOperator(result, x) to Residual class for PCG support#186
Merged
julianlitz merged 1 commit intomainfrom Feb 27, 2026
Merged
Add applySystemOperator(result, x) to Residual class for PCG support#186julianlitz merged 1 commit intomainfrom
julianlitz merged 1 commit intomainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #186 +/- ##
=======================================
Coverage 95.18% 95.18%
=======================================
Files 94 94
Lines 9345 9355 +10
=======================================
+ Hits 8895 8905 +10
Misses 450 450 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
|
I don't understand what is done in this PR. The description talks about new calculations but the existing calculations seem to have been changed in a non-trivial way (e.g. |
Collaborator
Author
|
In ResidualGive what we did before was RESIDUAL Now we do: APPLYA RESIDUAL Thats why the sign changed. |
EmilyBourne
approved these changes
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces the applySystemOperator(result, x) method to the Residual class, enabling computation of the system operator applied to a vector (A * x). Previously, the class only supported computing the residual, but PCG also requires direct application of the system operator.
Merge Request - GuideLine Checklist
Guideline to check code before resolve WIP and approval, respectively.
As many checkboxes as possible should be ticked.
Checks by code author:
Always to be checked:
If functions were changed or functionality was added:
If new functionality was added:
If new third party software is used:
If new mathematical methods or epidemiological terms are used:
Checks by code reviewer(s):