Feature/register gutenberg block

[LC43]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the asset management infrastructure by introducing dedicated functionality for registering Gutenberg blocks. It provides a new method within the AssetManager to simplify block registration and a new data class to structure block-related assets, improving organization and maintainability for WordPress block development.

Highlights

• New Gutenberg Block Registration Method: The AssetManager class now includes a register_gutenberg_block method, streamlining the process of registering Gutenberg blocks by handling script and style dependencies.
• Dedicated Gutenberg Block Data Class: A new GutenbergBlock class has been introduced to act as a data container for Gutenberg block assets, encapsulating source, identifier, and associated data.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• src/Infrastructure/Services/Assets/AssetManager.php
  • Added register_gutenberg_block method to register Gutenberg blocks with script and style handles.
• src/Infrastructure/Services/Assets/GutenbergBlock.php
  • Added new class GutenbergBlock to store source, identifier, and data for block assets.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces functionality for registering Gutenberg blocks. My review focuses on two main points. Firstly, the new register_gutenberg_block method in AssetManager.php could be improved to more safely handle optional script and style handles. Secondly, the newly added GutenbergBlock.php file contains a class that seems to be unused and has a misleading name and purpose, which could create confusion. I've left specific suggestions on how to address these points.

[LC43]

/gemini review

[gemini-code-assist]

Code Review

This pull request introduces a new method for registering Gutenberg blocks and refactors an existing method. I've found a critical issue in the refactoring of prepare_dependencies that could lead to an infinite loop or incorrect behavior, and I've provided a fix. Additionally, I've suggested improvements to the new register_gutenberg_block method to enhance its clarity and maintainability by using more descriptive parameter names and updating the documentation accordingly.

[gemini-code-assist]

Appending items to an array while iterating over it can lead to unexpected behavior, including infinite loops in older PHP versions or incorrect data. The current implementation will add prepared dependencies to the array without removing the original ones, effectively duplicating them in a different format. A safer approach is to build a new array with the prepared dependencies.

		$prepared = [];
		foreach ( $dependencies as $dependency_name ) {
			$dependency_src = $this->prepare_src( $dependency_name );
			$prepared[]     = $this->prepare_name( $dependency_src );
		}
		return $prepared;