fix(ui): Ensure splash screen scales to viewport height#639
Closed
aryanjsingh wants to merge 1 commit intoSableClient:devfrom
Closed
fix(ui): Ensure splash screen scales to viewport height#639aryanjsingh wants to merge 1 commit intoSableClient:devfrom
aryanjsingh wants to merge 1 commit intoSableClient:devfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The bug reporting screen, which uses the
SplashScreencomponent, was not scaling correctly to the browser's viewport height, causing content to be cropped. This was due to the component usingminHeight: '100%', which relies on parent elements having a defined height. The fix changes this tominHeight: '100vh', which correctly sizes the component based on the viewport's height, resolving the scaling issue.Changes
minHeightfrom100%to100vhin theSplashScreenstyle. Using the viewport height unit (vh) ensures the component's minimum height is always equal to the browser's viewport height, fixing the vertical scaling issue that caused content to be cropped.Related Issue
Closes #629