Harden YouTube URL handling in embed feature#599
Merged
7w1 merged 1 commit intoSableClient:devfrom Mar 31, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request refactors the
parseYoutubeLinkfunction inClientPreview.tsxto use the standardURLAPI for parsing YouTube URLs. This change improves the reliability and maintainability of the code by handling edge cases and reducing manual string manipulation.Improvements to YouTube URL parsing
parseYoutubeLinkto use theURLAPI for robust parsing of YouTube URLs, improving error handling and supporting more YouTube link formats.URLsearch parameters instead of manual string splitting, making the code more readable and less error-prone.Fixes https://github.com/SableClient/Sable/security/code-scanning/9
Type of change
Checklist:
AI disclosure:
No AI involved