Add support for displaying bundled previews MSC4095#590
Open
nushea wants to merge 4 commits intoSableClient:devfrom
Open
Add support for displaying bundled previews MSC4095#590nushea wants to merge 4 commits intoSableClient:devfrom
nushea wants to merge 4 commits intoSableClient:devfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR wishes to display bundled previews, should they be offered, in order to align to MSC4095.
Implements: matrix-org/matrix-spec-proposals#4095
Also i swear i didnt modify anything past line 75 in /src/app/components/url-preview/UrlPreviewCart.tsx i just added a param to UrlPreviewCard which pushed the length over the limit breaking the params into a table format, which then put the closing angle bracket right before the arguments which then made it no longer take one indentation which pushed the entire code to have one less indentation for prettier and if i am to change anything meaninglessly it just reverts it 😭
Type of change
Checklist:
AI disclosure:
A Jihn waswasa-ed the implementation to me.