Skip to content

fix(url-preview): guard against undefined query string in YouTube URL parser #584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
7w1 merged 1 commit into from
Mar 30, 2026
+11 −8
Merged

fix(url-preview): guard against undefined query string in YouTube URL parser #584

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fix-youtube-url-crash.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
default: patch
---

Fix crash when previewing non-video YouTube URLs (channels, @handles, etc.) that lack query parameters.
14 changes: 6 additions & 8 deletions src/app/components/url-preview/ClientPreview.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,21 +168,19 @@ function parseYoutubeLink(url: string): YoutubeLink | null {
[videoId] = split;
params = split[1]?.split('&');
} else if (url.includes('/shorts/')) {
const split = path.split('/shorts/');
const split = path.split('?');
[videoId] = split;
params = split[1]?.split('shorts');
params = split[1]?.split('&') ?? [];
} else if (url.includes('youtube.com')) {
params = path.split('?')[1].split('&');
videoId = params.find((s) => s.startsWith('v='), params)?.split('v=')[1];
params = path.split('?')[1]?.split('&') ?? [];
videoId = params.find((s) => s.startsWith('v='))?.split('v=')[1];
} else return null;

if (!videoId) return null;

// playlist is not used for the embed, it can be appended as is
const playlist = params ? params.find((s) => s.startsWith('list='), params) : undefined;
const timestamp = params
? params.find((s) => s.startsWith('t='), params)?.split('t=')[1]
: undefined;
const playlist = params ? params.find((s) => s.startsWith('list=')) : undefined;
const timestamp = params ? params.find((s) => s.startsWith('t='))?.split('t=')[1] : undefined;

return {
videoId,
Expand Down
Loading