Extensible dependent classes in Auth with builder methods#521
Open
AlexanderOMara wants to merge 1 commit intoSAML-Toolkits:4.x-devfrom
Open
Extensible dependent classes in Auth with builder methods#521AlexanderOMara wants to merge 1 commit intoSAML-Toolkits:4.x-devfrom
AlexanderOMara wants to merge 1 commit intoSAML-Toolkits:4.x-devfrom
Conversation
Contributor
|
Seems reasonable, I will add also builders for Error and Settings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basically just applying the convention used in
buildAuthnRequestto the other dependent classes, so they can be extended likeAuthnRequestcurrently can be.Among other things, this would make it possible to extend the different classes to use private keys not directly available to the application (ie. AWS KMS).