Added support for layerDiffuse, hiresFix, watermark and Region Prompting#253
Open
Sirsho1997 wants to merge 4 commits intomainfrom
Open
Added support for layerDiffuse, hiresFix, watermark and Region Prompting#253Sirsho1997 wants to merge 4 commits intomainfrom
Sirsho1997 wants to merge 4 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds new “advanced features” payload fields for image/video requests and moves them onto the common SerializableMixin request-serialization path.
Changes:
- Convert
IFluxKontextandIAdvancedFeaturestoSerializableMixinand addlayerDiffuse/hiresfixflags. - Introduce
IWatermarkand addwatermarksupport toIVideoAdvancedFeatures, updating video advanced-feature serialization. - Update image request building to rely on
_addOptionalField(..., advancedFeatures)instead of manual dict construction.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
runware/types.py |
Adds/updates advanced-feature dataclasses and serialization (IAdvancedFeatures, IWatermark, IVideoAdvancedFeatures.serialize). |
runware/base.py |
Switches image advancedFeatures injection to _addOptionalField; adds a debug print(json.dumps(...)) in video request flow. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sirsho1997
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added
IAdvancedFeatures:layerDiffuse,hiresfix,watermark(IWatermark), andregionalPrompting(IRegionalPromptingwithregions: List[IRegion]).IVideoAdvancedFeatures:IWatermark(text/image, position, opacity, colors) andwatermarkfield.IFluxKontext,IRegion,IRegionalPrompting,IWatermark,IAdvancedFeatures, andIVideoAdvancedFeaturesuseSerializableMixinfor request serialization.