Open
Conversation
Contributor
WalkthroughA folder management system for saved posts is introduced. The Changes
Sequence DiagramsequenceDiagram
actor User
participant Page as [domain].vue Page
participant PostSave as PostSave Component
participant Composable as usePocketbase Composable
participant Storage as Local Storage
rect rgba(100, 150, 200, 0.5)
Note over User,Storage: Delete Post Flow
User->>PostSave: Click Delete
PostSave->>Composable: removeSavedPostFolder(domain, id)
Composable->>Storage: Update savedPostFolderAssignments
Composable->>Composable: Filter post from savedPostList
Composable-->>PostSave: Folder cleaned up
PostSave-->>Page: Post removed from list
end
rect rgba(150, 200, 100, 0.5)
Note over User,Storage: Create Folder Flow
User->>Page: Click Create Folder
Page->>Composable: createSavedPostFolder(folderName)
Composable->>Storage: Add to savedPostFolders
Composable-->>Page: Returns true
Page->>Page: Update selectedFolderFilter
end
rect rgba(200, 150, 100, 0.5)
Note over User,Storage: Assign Post to Folder Flow
User->>Page: Select folder for post
Page->>Composable: setSavedPostFolder(domain, id, folderName)
Composable->>Storage: Update savedPostFolderAssignments
Composable-->>Page: Returns true
Page->>Page: Recompute filteredRows
end
Estimated code review effort🎯 4 (Complex) | ⏱️ ~50 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
✨ Simplify code
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Tip CodeRabbit can suggest fixes for GitHub Check annotations.Configure the |
Member
Author
|
@coderabbitai review |
Contributor
✅ Actions performedReview triggered.
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
composables/usePocketbase.ts (1)
146-161: 🧹 Nitpick | 🔵 TrivialConsider whether
savedPostFolderAssignmentsneeds to be exported.The
savedPostFolderAssignmentsstate is exported but doesn't appear to be used directly by consumers—they interact throughgetSavedPostFolderandsetSavedPostFolder. If it's only needed internally, consider removing it from the return object to keep the API surface minimal.♻️ Suggested change
return { email, license, subscription_expires_at, savedPostList, savedPostFolders, - savedPostFolderAssignments, getSavedPostFolder, setSavedPostFolder, removeSavedPostFolder, createSavedPostFolder, deleteSavedPostFolder }🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@composables/usePocketbase.ts` around lines 146 - 161, Remove savedPostFolderAssignments from the module's public API: if consumers only use getSavedPostFolder and setSavedPostFolder, stop exporting savedPostFolderAssignments from the return object and keep it as an internal reactive state referenced by getSavedPostFolder and setSavedPostFolder; update the returned object to omit savedPostFolderAssignments, verify getSavedPostFolder and setSavedPostFolder still access the internal variable, and run a project-wide search for savedPostFolderAssignments to ensure no external code expects it to be exported.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@pages/premium/saved-posts/`[domain].vue:
- Around line 314-331: The onCreateFolderClick handler duplicates normalization
logic instead of reusing the composable's normalizeSavedPostFolderName which
risks divergence; update so createSavedPostFolder either returns the normalized
folder name on success (instead of boolean) or export and call
normalizeSavedPostFolderName from the composable, then set
selectedFolderFilter.value to the returned/normalized name; adjust
onCreateFolderClick to use the normalized value and handle falsy return as
failure, and update createSavedPostFolder and any callers to match the new
return contract.
---
Outside diff comments:
In `@composables/usePocketbase.ts`:
- Around line 146-161: Remove savedPostFolderAssignments from the module's
public API: if consumers only use getSavedPostFolder and setSavedPostFolder,
stop exporting savedPostFolderAssignments from the return object and keep it as
an internal reactive state referenced by getSavedPostFolder and
setSavedPostFolder; update the returned object to omit
savedPostFolderAssignments, verify getSavedPostFolder and setSavedPostFolder
still access the internal variable, and run a project-wide search for
savedPostFolderAssignments to ensure no external code expects it to be exported.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: fe77eb13-d873-4a61-8f35-6373338aa4b0
📒 Files selected for processing (3)
components/pages/posts/post/PostSave.vuecomposables/usePocketbase.tspages/premium/saved-posts/[domain].vue
Comment on lines
+314
to
+331
| function onCreateFolderClick() { | ||
| const folderNamePrompt = prompt('Folder name') | ||
|
|
||
| if (folderNamePrompt == null) { | ||
| return | ||
| } | ||
|
|
||
| const wasFolderCreated = createSavedPostFolder(folderNamePrompt) | ||
|
|
||
| if (!wasFolderCreated) { | ||
| toast.error('Invalid or duplicate folder name') | ||
| return | ||
| } | ||
|
|
||
| const normalizedFolderName = folderNamePrompt.trim().replace(/\s+/g, ' ') | ||
|
|
||
| selectedFolderFilter.value = normalizedFolderName | ||
| } |
Contributor
There was a problem hiding this comment.
🧹 Nitpick | 🔵 Trivial
Duplicated normalization logic could diverge.
Line 328 duplicates the folder name normalization that exists in normalizeSavedPostFolderName. If the normalization logic changes in the composable, this inline version could produce mismatched folder names.
♻️ Suggested refactor: Export and reuse the normalizer
Consider exporting normalizeSavedPostFolderName from the composable or having createSavedPostFolder return the normalized name:
- const wasFolderCreated = createSavedPostFolder(folderNamePrompt)
-
- if (!wasFolderCreated) {
- toast.error('Invalid or duplicate folder name')
- return
- }
-
- const normalizedFolderName = folderNamePrompt.trim().replace(/\s+/g, ' ')
-
- selectedFolderFilter.value = normalizedFolderName
+ const createdFolderName = createSavedPostFolder(folderNamePrompt)
+
+ if (!createdFolderName) {
+ toast.error('Invalid or duplicate folder name')
+ return
+ }
+
+ selectedFolderFilter.value = createdFolderNameThis would require updating createSavedPostFolder to return the normalized name on success instead of true.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@pages/premium/saved-posts/`[domain].vue around lines 314 - 331, The
onCreateFolderClick handler duplicates normalization logic instead of reusing
the composable's normalizeSavedPostFolderName which risks divergence; update so
createSavedPostFolder either returns the normalized folder name on success
(instead of boolean) or export and call normalizeSavedPostFolderName from the
composable, then set selectedFolderFilter.value to the returned/normalized name;
adjust onCreateFolderClick to use the normalized value and handle falsy return
as failure, and update createSavedPostFolder and any callers to match the new
return contract.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
pnpm exec nuxi typecheck\\(fails with many pre-existing repo type/module issues unrelated to this change, plus a local vue-router volar dependency resolution problem in this environment)pnpm test\\(fails because existing repo tests import missing \@nuxt/test-utils\\)Feedback
Summary by CodeRabbit
Release Notes