Skip to content

Add CCryptoLib and ECNet2 as libraries in ROM#9

Open
scmcgowen wants to merge 3 commits intoReconnectedCC:mainfrom
scmcgowen:main
Open

Add CCryptoLib and ECNet2 as libraries in ROM#9
scmcgowen wants to merge 3 commits intoReconnectedCC:mainfrom
scmcgowen:main

Conversation

@scmcgowen
Copy link
Copy Markdown
Contributor

This PR adds two semi-large and quite common libraries to the ROM for easy access.
This also marks me as the maintainer of those modules in the ROM (not the upstream, just the package in the ROM)
(there's no file for that currently, so its just here in the PR body, maybe consider adding such a file somewhere?)

@dimaguy
Copy link
Copy Markdown
Contributor

dimaguy commented Apr 4, 2026

I'm not sure we want to include cryptography libraries in the ROM, especially with the upcoming Classic Peripherals' cryptography accelerators

@scmcgowen
Copy link
Copy Markdown
Contributor Author

Afaik there's not much overlap in algorithms here, except for sha256 and random

@dimaguy
Copy link
Copy Markdown
Contributor

dimaguy commented Apr 4, 2026

Another 2 reasons crypto libs were never added (even on sc) was because a vulnerability in the standard lib would immediately open up all the services using it, and because it discourages people getting out of their comfort zone to figure out how to best secure their usecases.
"If the only tool youve got at hand is a hammer, everything starts to look like a nail"

Scratch that, its a weak argument because crypto accelerators do that as well.

We're not worried about big libraries being used either, we're going to mount cc save dir with a dedup fs soon enough.

@dimaguy
Copy link
Copy Markdown
Contributor

dimaguy commented Apr 4, 2026

Either way, pushing ecnet is a no-go, straight up railroading the learning process on securing a network

@scmcgowen
Copy link
Copy Markdown
Contributor Author

as far as big libraries, even if you are running a dedup fs, we still only have 1mb of base computer storage (yes, there's 8mb on disks, but disks aren't in package.path by default, and there's no way to do that in a startup.lua because package is created for each new program by the shell

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants