Add CCryptoLib and ECNet2 as libraries in ROM#9
Add CCryptoLib and ECNet2 as libraries in ROM#9scmcgowen wants to merge 3 commits intoReconnectedCC:mainfrom
Conversation
|
I'm not sure we want to include cryptography libraries in the ROM, especially with the upcoming Classic Peripherals' cryptography accelerators |
|
Afaik there's not much overlap in algorithms here, except for sha256 and random |
|
Another 2 reasons crypto libs were never added (even on sc) was because a vulnerability in the standard lib would immediately open up all the services using it, We're not worried about big libraries being used either, we're going to mount cc save dir with a dedup fs soon enough. |
|
Either way, pushing ecnet is a no-go, straight up railroading the learning process on securing a network |
|
as far as big libraries, even if you are running a dedup fs, we still only have 1mb of base computer storage (yes, there's 8mb on disks, but disks aren't in |
This PR adds two semi-large and quite common libraries to the ROM for easy access.
This also marks me as the maintainer of those modules in the ROM (not the upstream, just the package in the ROM)
(there's no file for that currently, so its just here in the PR body, maybe consider adding such a file somewhere?)