Minimum viable fix for enums from vm namespaces clashing with identifiers from includes#568
Open
paulie-g wants to merge 1 commit intoReadyTalk:masterfrom
Open
Minimum viable fix for enums from vm namespaces clashing with identifiers from includes#568paulie-g wants to merge 1 commit intoReadyTalk:masterfrom
paulie-g wants to merge 1 commit intoReadyTalk:masterfrom
Conversation
Techcable
added a commit
to Techcable/avian
that referenced
this pull request
Jul 12, 2023
Minimum viable fix for enums from vm namespaces clashing with identifiers from math includes Fixes ReadyTalk#569
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Various identifiers from Avian's vm::OpCode enum - fadd, fmul, fsub, fdiv - clash with fadd, fmul, fsub, fdiv declared elsewhere when compiling on a modern Linux system. This patch is a kludge obviously, but given that this is not an actively maintained project, I chose to make it as small as possible so it doesn't clash with other patches in future.