Skip to content

feat(7652): added stringsAsFactors to test 2365.2#7655

Merged
aitap merged 4 commits intomasterfrom
fix/7652_dcast_test_issue
Mar 3, 2026
Merged

feat(7652): added stringsAsFactors to test 2365.2#7655
aitap merged 4 commits intomasterfrom
fix/7652_dcast_test_issue

Conversation

@manmita
Copy link
Contributor

@manmita manmita commented Mar 1, 2026

Closes #7652

@manmita manmita requested a review from MichaelChirico as a code owner March 1, 2026 18:48
@codecov
Copy link

codecov bot commented Mar 1, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.02%. Comparing base (67e7840) to head (e0ac167).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7655   +/-   ##
=======================================
  Coverage   99.02%   99.02%           
=======================================
  Files          87       87           
  Lines       16897    16897           
=======================================
  Hits        16733    16733           
  Misses        164      164           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@manmita
Copy link
Contributor Author

manmita commented Mar 1, 2026

@aitap Please let me know if we should add a note to news.md in this case as its not a feature or fix, just a test fix.

@manmita
Copy link
Contributor Author

manmita commented Mar 1, 2026

I have tested with R 3.5.0, the tests pass now

@manmita manmita requested a review from aitap March 1, 2026 19:18
Copy link
Member

@aitap aitap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@aitap aitap merged commit 7698fe0 into master Mar 3, 2026
11 checks passed
@aitap aitap deleted the fix/7652_dcast_test_issue branch March 3, 2026 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

dcast() test 2365.2 fail on R 3.5.0

2 participants