Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions app/helpers/perron/markdown_helper.rb
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,11 @@

module Perron
module MarkdownHelper
def markdownify(content = nil, process: [], resource: nil, &block)
def markdownify(content = nil, process: nil, resource: nil, &block)
text = block_given? ? capture(&block).strip_heredoc : content
processors = (process.nil? || process.empty?) ? Perron.configuration.default_processors : process

Perron::Markdown.render(text, processors: process, resource: resource || @resource)
Perron::Markdown.render(text, processors: processors, resource: resource || @resource)
end
end
end
2 changes: 2 additions & 0 deletions lib/perron/configuration.rb
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,8 @@ def initialize

@config.markdown_options = {}

@config.default_processors = []

@config.search_scope = []

@config.sitemap = ActiveSupport::OrderedOptions.new
Expand Down
49 changes: 49 additions & 0 deletions test/helpers/markdown_helper_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,16 @@
class MarkdownHelperTest < ActionView::TestCase
include Perron::MarkdownHelper

setup do
@original_default_processors = Perron.configuration.default_processors
end

teardown do
Perron.configure do |config|
config.default_processors = @original_default_processors
end
end

test "passes content, processors, and resource correctly through the chain" do
@resource = Content::Post.find!("sample-post")
html = markdownify("<p>Some text.</p>", process: ["dummy_processor"])
Expand All @@ -26,4 +36,43 @@ class MarkdownHelperTest < ActionView::TestCase

assert_dom_equal "## Hello", html.strip
end

test "uses default_processors from config when none passed" do
Perron.configure do |config|
config.default_processors = %w[dummy_processor]
end

@resource = Content::Post.find!("sample-post")
html = markdownify("<p>Some text.</p>")

expected_class = @resource.metadata.dig("processor_class") || "processed-by-dummy"
assert_dom_equal %(<p class="#{expected_class}">Some text.</p>), html.strip
end

test "uses default_processors from config when empty array passed" do
Perron.configure do |config|
config.default_processors = %w[dummy_processor]
end

@resource = Content::Post.find!("sample-post")
html = markdownify("<p>Some text.</p>", process: [])

expected_class = @resource.metadata.dig("processor_class") || "processed-by-dummy"
assert_dom_equal %(<p class="#{expected_class}">Some text.</p>), html.strip
end

test "explicit process argument overrides default_processors" do
Perron.configure do |config|
config.default_processors = %w[target_blank]
end

html = markdownify('<a href="http://example.com">Link</a><img src="test.jpg">', process: ["lazy_load_images"])

assert_includes html, 'loading="lazy"'
refute_includes html, 'target="_blank"'
end

test "default_processors defaults to empty array" do
assert_equal [], Perron.configuration.default_processors
end
end
Loading