Skip to content

Small fix for ignored adjoint flag in BraidingTensor #392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lkdvos merged 3 commits into from
Mar 31, 2026
+13 −7
Merged

Small fix for ignored adjoint flag in BraidingTensor #392

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
46b3e39
fix braiding factor with adjoint
lkdvos Mar 31, 2026
d865b39
add tests that capture this
lkdvos Mar 31, 2026
9ba26c9
use `subblock`
lkdvos Mar 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions src/tensors/braidingtensor.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,8 +99,8 @@ function _braiding_factor(f₁, f₂, inv::Bool = false)
return r
end

@inline function Base.getindex(
b::BraidingTensor, f₁::FusionTree{I, 2}, f₂::FusionTree{I, 2}
@inline function subblock(
b::BraidingTensor, (f₁, f₂)::Tuple{FusionTree{I, 2}, FusionTree{I, 2}}
) where {I <: Sector}
I == sectortype(b) || throw(SectorMismatch())
c = f₁.coupled
Expand All @@ -126,10 +126,6 @@ end
end
return data
end
@inline function Base.getindex(b::BraidingTensor, ::Nothing, ::Nothing)
sectortype(b) === Trivial || throw(SectorMismatch())
return getindex(b)
end

# efficient copy constructor
Base.copy(b::BraidingTensor) = b
Expand Down Expand Up @@ -169,7 +165,7 @@ function block(b::BraidingTensor, s::Sector)

for ((f₁, f₂), (sz, str, off)) in pairs(subblockstructure(space(b)))
(f₁.coupled == f₂.coupled == s) || continue
r = _braiding_factor(f₁, f₂)
r = _braiding_factor(f₁, f₂, b.adjoint)
isnothing(r) && continue
# change offset to account for single block
subblock = StridedView(data, sz, str, off - base_offset)
Expand Down
10 changes: 10 additions & 0 deletions test/tensors/planar.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,16 @@ using .TestSetup
for (f1, f2) in fusiontrees(t1)
@test t1[f1, f2] ≈ t3[f1, f2]
end

t5 = @inferred TensorMap(t2')
t6 = braid(id(storagetype(t2), domain(t2')), ((2, 1), (3, 4)), (4, 3, 2, 1))
@test t5 ≈ t6
for (c, b) in blocks(t1')
@test block(t1', c) ≈ b ≈ block(t5, c)
end
for (f1, f2) in fusiontrees(t1')
@test t1'[f1, f2] ≈ t5[f1, f2]
end
end
end

Expand Down
Loading