Refactor groundstate algorithms to use find_groundstate! and GeometryStyle dispatch#410
Draft
AFeuerpfeil wants to merge 4 commits intoQuantumKitHub:mainfrom
Draft
Refactor groundstate algorithms to use find_groundstate! and GeometryStyle dispatch#410AFeuerpfeil wants to merge 4 commits intoQuantumKitHub:mainfrom
AFeuerpfeil wants to merge 4 commits intoQuantumKitHub:mainfrom
Conversation
…dstate! on `GeometryStyle` instead of MPS type.
Contributor
|
Your PR no longer requires formatting changes. Thank you for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
find_groundstatealgorithms previously dispatched on concrete MPS types (InfiniteMPS,AbstractFiniteMPS) and mixed mutating/non-mutating semantics. This PR refactors the interface to follow the conventions:find_groundstate!variants for all algorithms (VUMPS, DMRG, DMRG2, IDMRG, IDMRG2, GradientGrassmann) that update ψ in-place, reusing its storage. The non-mutatingfind_groundstatenow simply copies ψ and delegates tofind_groundstate!.GeometryStyle(InfiniteChainStyle/FiniteChainStyle), making the algorithms more general and decoupled from specific state types.