Conversation
Codecov Report❌ Patch coverage is
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Free Tier Details
You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Greptile SummaryThis PR upgrades the
Important verification needed: The new Confidence Score: 4/5
Important Files Changed
Last reviewed commit: ee95225 |
Done for a request here: home-assistant/core#164133
Replaces: #753
Fixes: #751
Not sure if there is a cleaner way to somehow still support older versions or not. I believe nothing else in core should be requiring under 4.0 now.
Note
Medium Risk
Updates a core dependency and rewires rate-limiting behavior around login and home-data fetches, which could change throttling semantics and user-visible error timing.
Overview
Upgrades
pyrate-limiterto>=4,<5(and updatesuv.lock) and adaptsRoborockApiClientrate limiting to the v4 API.web_api.pydropsBucketFullExceptionhandling and switches to boolean-basedtry_acquire_async(..., blocking=True, timeout=1)for login and non-blockingtry_acquire(..., blocking=False)for home data, raisingRoborockRateLimitwhen acquisition fails. Tests update theskip_rate_limitfixture to mock the new async limiter call viaAsyncMock.Written by Cursor Bugbot for commit ee95225. This will update automatically on new commits. Configure here.