Open
Conversation
We'll need a newer one to use cmake binaries for riscv64. Signed-off-by: Trevor Gamblin <tgamblin@baylibre.com>
Fix policy definitions and minimum required CMake version in CMakeLists.txt so that we can build using riscv64 wheels. Signed-off-by: Trevor Gamblin <tgamblin@baylibre.com>
Author
|
Hmm, looks like there are some macos errors I'll have to look into... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This breaks two commits out of #214 (as requested) since they're more broadly applicable. The first commit just unpins the cmake version, since the one listed is fairly old. The second then tweaks the CMake expectations for x265. Both of these together should help the project build with newer tooling going forward and also prime it for adding riscv64 builds (as per #214 ).