Add EnumAttr base type and valve/actuator attrs#55
Draft
agarnhart wants to merge 3 commits intoProject-Haystack:masterfrom
Draft
Add EnumAttr base type and valve/actuator attrs#55agarnhart wants to merge 3 commits intoProject-Haystack:masterfrom
agarnhart wants to merge 3 commits intoProject-Haystack:masterfrom
Conversation
Introduce Valve and Damper as abstract Equip bases for non-actuated equipment. ValveActuator and DamperActuator become intersection types (Actuator & Valve, Actuator & Damper). Adds *thermostatic global marker for feature layering on valves.
7 new Enum types for valve/actuator classification: ValveFunction (11 values), ValveBodyType, ValvePorts, ActuatorFailPosition, ActuatorDirection, ActuatorControlAction, ActuatorMechanism. Adds actuatorDirection slot on Actuator. ValveFunction scoped to piping role — pressureIndependent and thermostatic are feature markers, not function values.
EnumAttr completes the Attr type family alongside StrAttr, NumberAttr,
DateAttr. Adds 6 typed attr specs split by design (engineer-specified)
vs rated (manufacturer nameplate):
Design: ValveFunctionDesignAttr, ActuatorFailPositionDesignAttr
Rated: ValvePortsRatedAttr, ValveBodyTypeRatedAttr,
ActuatorControlActionRatedAttr, ActuatorMechanismRatedAttr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #54.
EnumAttrcompletes the Attr type family alongside StrAttr, NumberAttr, DateAttr.6 typed attr specs split by whether the engineer or manufacturer provides the value:
ValveFunctionDesignAttr,ActuatorFailPositionDesignAttrValvePortsRatedAttr,ValveBodyTypeRatedAttr,ActuatorControlActionRatedAttr,ActuatorMechanismRatedAttrThe test for spec vs attr: does changing this property change which points you need or how you interpret the data? If yes, it belongs on the spec (like
actuatorDirection). If no, it's nameplate or design data and belongs in ph.attrs.Files:
ph.attrs/base.xeto,ph.attrs/valve.xeto(new),ph.attrs/actuator.xeto(new)