Add Valve and Damper abstract base specs#53
Draft
agarnhart wants to merge 1 commit intoProject-Haystack:masterfrom
Draft
Add Valve and Damper abstract base specs#53agarnhart wants to merge 1 commit intoProject-Haystack:masterfrom
agarnhart wants to merge 1 commit intoProject-Haystack:masterfrom
Conversation
Introduce Valve and Damper as abstract Equip bases for non-actuated equipment. ValveActuator and DamperActuator become intersection types (Actuator & Valve, Actuator & Damper). Adds *thermostatic global marker for feature layering on valves.
This was referenced Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
ValveandDamperas abstract Equip bases so non-actuated valves (manual isolation, check, PRV, TMV) and non-actuated dampers (fire/smoke, backdraft) have a home in the ontology without requiring actuator metadata.ValveActuatorbecomesActuator & ValveandDamperActuatorbecomesActuator & Damper— intersection types that compose valve/damper identity with actuator control.Also adds
*thermostaticglobal marker to PhEntity. Together with the existing*pressureIndependent, these are feature markers that can be layered onto valves freely rather than being enum values (a PICV isvalve, control, pressureIndependent; a TMV isvalve, mixing, thermostatic).Files:
ph/equip.xeto,ph/entity.xeto