Open
Conversation
The release should now be attribute to the GitHub App that's used, rather than github-actions. But for real this time.
Piccirello
commented
Mar 10, 2026
Comment on lines
-200
to
+194
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| GH_TOKEN: ${{ steps.releaser.outputs.token }} |
Member
Author
There was a problem hiding this comment.
Of course attribution wasn't working, we were passing the wrong token.
Member
Author
There was a problem hiding this comment.
@rafaeelaudibert sanity check: was there an explicit reason this uses the default GITHUB_TOKEN?
Contributor
|
Last reviewed commit: 63fd980 |
Piccirello
commented
Mar 10, 2026
Comment on lines
69
to
72
| permissions: | ||
| contents: write | ||
| actions: write | ||
| id-token: write |
Member
Author
There was a problem hiding this comment.
I audited whether we could remove contents and actions perms, but it looks like the "Dispatch generate-references" step may still need them.
Contributor
posthog-python Compliance ReportDate: 2026-03-10 21:44:12 UTC ✅ All Tests Passed!29/29 tests passed Capture Tests✅ 29/29 tests passed View Details
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The release should now be attributed to the GitHub App that's used, rather than github-actions. But for real this time.