Update release.yml to support commit signing#458
Open
Piccirello wants to merge 5 commits intomasterfrom
Open
Conversation
The `planetscale/ghcommit-action` action uses ghcommit which uses the GitHub API, which supports commit signing by default. This removes the need to configure a GPG key in our Action.
Comment on lines
142
to
150
| - name: Commit release changes | ||
| id: commit-release | ||
| uses: planetscale/ghcommit-action@25309d8005ac7c3bcd61d3fe19b69e0fe47dbdde # v0.2.20 | ||
| with: | ||
| commit_message: "chore: Release v${{ steps.sampo-release.outputs.new_version }}" | ||
| repo: ${{ github.repository }} | ||
| branch: master | ||
| env: | ||
| GITHUB_TOKEN: ${{ steps.releaser.outputs.token }} |
Member
There was a problem hiding this comment.
What user.name and user.email is it going to use? 🤔
Member
Author
There was a problem hiding this comment.
The GitHub API will use the identity associated with the GITHUB_TOKEN. In this case that would be the "Releaser (posthog-python)" GitHub App.
Contributor
|
Last reviewed commit: 18a2943 |
Contributor
posthog-python Compliance ReportDate: 2026-03-10 02:48:44 UTC ✅ All Tests Passed!29/29 tests passed Capture Tests✅ 29/29 tests passed View Details
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
planetscale/ghcommit-actionaction uses ghcommit which uses the GitHub API, which supports commit signing by default. This removes the need to configure a GPG key in our Action.I have not tested this and I think it would be tricky to test. It seems reasonable to merge, attempt a release, and roll back if it breaks.