feat: add training stability guards and fix transformers 5.2.0 compat…#964
Merged
research4pan merged 1 commit intoOptimalScale:mainfrom Mar 23, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces several hardware-aware safeguards to prevent common crashes during training and improves compatibility with newer library versions.
Improvements:
BF16 Auto-Fallback: Automatically falls back to fp16 if bf16 is requested on unsupported hardware (pre-Ampere GPUs), preventing cryptic CUDA errors.
Gradient Checkpointing Guard: Automatically disables use_cache when gradient checkpointing is active to prevent known training conflicts.
Vocabulary Mismatch Guard: Automatically resizes model embeddings if the tokenizer's vocabulary exceeds the model's dimension (essential when using custom chat templates).
Library Compatibility:
Fixed AttributeError for overwrite_output_dir appearing in transformers >= 5.2.0.
Added pytest.importorskip for sglang to prevent test collection crashes in environments without sglang.