Add animation codable support and display list effects#849
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #849 +/- ##
==========================================
+ Coverage 26.53% 27.19% +0.65%
==========================================
Files 671 673 +2
Lines 44009 44166 +157
==========================================
+ Hits 11676 12009 +333
+ Misses 32333 32157 -176 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
New Codable Animation Types: Introduced
CodableAnimationstruct to handle protobuf encoding/decoding of animation objects with support for bezier, spring, fluid spring, delay, repeat, and speed modifiersEffect Animation System: Added
CodableEffectAnimationandDisplayListAnimationsmodule with support for:EffectAnimationprotocol for animatable effect valuesEffectAnimatorfor frame-by-frame evaluationProtocol Refactoring:
EncodableAnimationprotocol definition toCustomAnimation.swift_DisplayList_AnyEffectAnimationto useCodableEffectAnimation.TagDelayAnimation,SpeedAnimation) package-scopedTest Coverage: Added comprehensive protobuf encoding/decoding tests for:
CodableAnimationTests: All animation types and modifiersCodableEffectAnimationTests: All effect animation typesCodableEffectAnimationDualTests: SwiftUI compatibility testsTest Infrastructure: Enhanced
ProtobufTestHelperto support non-Equatabletypes through re-encoding validation