-
Notifications
You must be signed in to change notification settings - Fork 64
Add ViewRenderer and ViewCache API support #848
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
b4f57c8
[NFC] Merge EmptyViewRendererHost into ViewRendererHost file
Kyle-Ye 7956c2e
Update DisplayListViewRenderer
Kyle-Ye 5b9e7a1
Optimize ViewRenderer code
Kyle-Ye 4d19295
Implement ViewRasterizer
Kyle-Ye 3afd664
Update RendererConfiguration
Kyle-Ye dd48a73
Add CAPresentationModifier.h
Kyle-Ye 1e81add
Add DisplayListViewCache Stub
Kyle-Ye b3071c6
Implement ViewCache.setAsyncValue
Kyle-Ye e5b7495
Update DisplayListPlatformEffect
Kyle-Ye b5b9515
Update CALayer API
Kyle-Ye d5a8ffd
Update DisplayListViewCache.update and Result
Kyle-Ye b202448
Update ViewCache.prepare
Kyle-Ye 2d51240
Update commitAsyncValues
Kyle-Ye 50f954a
Update clearAsyncValues
Kyle-Ye 8275376
Update ViewCache.reclaim
Kyle-Ye 6e7cb70
Complete DisplayListViewCache
Kyle-Ye 7aeb2dc
Update DisplayListViewPlatform
Kyle-Ye 100e832
Fix compile error
Kyle-Ye 23432a7
Rename CoreGraphicsShims to QuartzCoreShims and fix compile guard
Kyle-Ye File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sources/OpenSwiftUICore/Render/DisplayList/DisplayList.swift:493matchesTopLevelStructure(of:)treats any.effectpair as structurally identical, which can letViewUpdater.updateAsyncproceed even if the effect kind changed (potentially applying async updates against an incompatible structure).Severity: medium
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.