Skip to content

Chore | Remove renamed trait methods #512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
matiasperrone-exo wants to merge 2 commits into
base: main
Choose a base branch
from
+12 −76
Open

Chore | Remove renamed trait methods #512

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ed1d053
chore: Remove renamed trait methods
matiasperrone-exo Feb 25, 2026
18dce12
chore: Remove trait alias
matiasperrone-exo Feb 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 5 additions & 30 deletions app/Http/Controllers/Apis/Protected/Summit/OAuth2SummitBadgeTypeApiController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,25 +97,15 @@ protected function getOrderRules():array{
];
}

use GetAllBySummit {
getAllBySummit as protected traitGetAllBySummit;
}
use GetAllBySummit;

use GetSummitChildElementById {
get as protected traitGet;
}
use GetSummitChildElementById;

use AddSummitChildElement {
add as protected traitAdd;
}
use AddSummitChildElement;

use UpdateSummitChildElement {
update as protected traitUpdate;
}
use UpdateSummitChildElement;

use DeleteSummitChildElement {
delete as protected traitDelete;
}
use DeleteSummitChildElement;

#[OA\Get(
path: "/api/v1/summits/{id}/badge-types",
Expand Down Expand Up @@ -202,9 +192,6 @@ protected function getOrderRules():array{
new OA\Response(response: Response::HTTP_INTERNAL_SERVER_ERROR, description: "Server Error")
]
)]
public function getAllBySummit($summit_id) {
return $this->traitGetAllBySummit($summit_id);
}

#[OA\Get(
path: "/api/v1/summits/{id}/badge-types/{badge_type_id}",
Expand Down Expand Up @@ -268,9 +255,6 @@ public function getAllBySummit($summit_id) {
new OA\Response(response: Response::HTTP_INTERNAL_SERVER_ERROR, description: "Server Error")
]
)]
public function get($summit_id, $badge_type_id) {
return $this->traitGet($summit_id, $badge_type_id);
}

#[OA\Post(
path: "/api/v1/summits/{id}/badge-types",
Expand Down Expand Up @@ -316,9 +300,6 @@ public function get($summit_id, $badge_type_id) {
new OA\Response(response: Response::HTTP_INTERNAL_SERVER_ERROR, description: "Server Error")
]
)]
public function add($summit_id) {
return $this->traitAdd($summit_id);
}

#[OA\Put(
path: "/api/v1/summits/{id}/badge-types/{badge_type_id}",
Expand Down Expand Up @@ -371,9 +352,6 @@ public function add($summit_id) {
new OA\Response(response: Response::HTTP_INTERNAL_SERVER_ERROR, description: "Server Error")
]
)]
public function update($summit_id, $badge_type_id) {
return $this->traitUpdate($summit_id, $badge_type_id);
}

#[OA\Delete(
path: "/api/v1/summits/{id}/badge-types/{badge_type_id}",
Expand Down Expand Up @@ -416,9 +394,6 @@ public function update($summit_id, $badge_type_id) {
new OA\Response(response: Response::HTTP_INTERNAL_SERVER_ERROR, description: "Server Error")
]
)]
public function delete($summit_id, $badge_type_id) {
return $this->traitDelete($summit_id, $badge_type_id);
}

/**
* @param array $payload
Expand Down
21 changes: 3 additions & 18 deletions app/Http/Controllers/Apis/Protected/Summit/OAuth2SummitDocumentsApiController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,17 +42,11 @@ class OAuth2SummitDocumentsApiController extends OAuth2ProtectedController
{
// traits

use GetAllBySummit {
getAllBySummit as protected traitGetAllBySummit;
}
use GetAllBySummit;

use GetSummitChildElementById {
get as protected traitGet;
}
use GetSummitChildElementById;

use DeleteSummitChildElement {
delete as protected traitDelete;
}
use DeleteSummitChildElement;

use RequestProcessor;

Expand Down Expand Up @@ -163,9 +157,6 @@ public function __construct
new OA\Response(response: Response::HTTP_INTERNAL_SERVER_ERROR, description: "Server Error")
]
)]
public function getAllBySummit($summit_id) {
return $this->traitGetAllBySummit($summit_id);
}

#[OA\Get(
path: "/api/v1/summits/{id}/summit-documents/{document_id}",
Expand Down Expand Up @@ -220,9 +211,6 @@ public function getAllBySummit($summit_id) {
new OA\Response(response: Response::HTTP_INTERNAL_SERVER_ERROR, description: "Server Error")
]
)]
public function get($summit_id, $document_id) {
return $this->traitGet($summit_id, $document_id);
}

#[OA\Post(
path: "/api/v1/summits/{id}/summit-documents",
Expand Down Expand Up @@ -486,9 +474,6 @@ public function update(LaravelRequest $request, $summit_id, $document_id){
new OA\Response(response: Response::HTTP_INTERNAL_SERVER_ERROR, description: "Server Error")
]
)]
public function delete($summit_id, $document_id) {
return $this->traitDelete($summit_id, $document_id);
}

/**
* @inheritDoc
Expand Down
32 changes: 4 additions & 28 deletions app/Http/Controllers/Apis/Protected/Summit/OAuth2SummitSubmissionInvitationApiController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,21 +48,13 @@ final class OAuth2SummitSubmissionInvitationApiController extends OAuth2Protecte

use ParametrizedGetAll;

use GetSummitChildElementById {
get as protected traitGet;
}
use GetSummitChildElementById;

use DeleteSummitChildElement {
delete as protected traitDelete;
}
use DeleteSummitChildElement;

use AddSummitChildElement {
add as protected traitAdd;
}
use AddSummitChildElement;

use UpdateSummitChildElement {
update as protected traitUpdate;
}
use UpdateSummitChildElement;

/**
* @var ISummitRepository
Expand Down Expand Up @@ -578,10 +570,6 @@ protected function updateChild(Summit $summit, int $child_id, array $payload): I
new OA\Response(response: Response::HTTP_INTERNAL_SERVER_ERROR, description: "Server Error")
]
)]
public function get($summit_id, $invitation_id)
{
return $this->traitGet($summit_id, $invitation_id);
}

#[OA\Post(
path: "/api/v1/summits/{id}/submission-invitations",
Expand Down Expand Up @@ -632,10 +620,6 @@ public function get($summit_id, $invitation_id)
new OA\Response(response: Response::HTTP_INTERNAL_SERVER_ERROR, description: "Server Error")
]
)]
public function add($summit_id)
{
return $this->traitAdd($summit_id);
}

#[OA\Put(
path: "/api/v1/summits/{id}/submission-invitations/{invitation_id}",
Expand Down Expand Up @@ -693,10 +677,6 @@ public function add($summit_id)
new OA\Response(response: Response::HTTP_INTERNAL_SERVER_ERROR, description: "Server Error")
]
)]
public function update($summit_id, $invitation_id)
{
return $this->traitUpdate($summit_id, $invitation_id);
}

#[OA\Delete(
path: "/api/v1/summits/{id}/submission-invitations/{invitation_id}",
Expand Down Expand Up @@ -744,10 +724,6 @@ public function update($summit_id, $invitation_id)
new OA\Response(response: Response::HTTP_INTERNAL_SERVER_ERROR, description: "Server Error")
]
)]
public function delete($summit_id, $invitation_id)
{
return $this->traitDelete($summit_id, $invitation_id);
}

#[OA\Delete(
path: "/api/v1/summits/{id}/submission-invitations/all",
Expand Down