Fix | Remove incorrectly added functions when creating OpenAPI documentation#507
Merged
Fix | Remove incorrectly added functions when creating OpenAPI documentation#507
Conversation
7865e49 to
fa687c2
Compare
martinquiroga-exo
suggested changes
Feb 23, 2026
Contributor
martinquiroga-exo
left a comment
There was a problem hiding this comment.
@matiasperrone-exo this is unclean, either revert the entire PR so no documentation code is present, since only removing the culprit methods will leave swagger headless, or override them correctly so they get picked up:
use AddSummitChildElement {
add as private traitAdd;
}
#[OA\Post(...)]
public function add($summit_id)
{
return $this->traitAdd($summit_id);
}
I defer to @smarcet on which one fits best in this case.
Collaborator
|
@martinquiroga-exo please follow this pattern swagger framework pick up the documentation automatically |
smarcet
approved these changes
Feb 24, 2026
Collaborator
smarcet
left a comment
There was a problem hiding this comment.
LGTM its follows the approved pattern
Contributor
|
Just realised the "From trait" comment. Great then. Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task
Ref: https://app.clickup.com/t/86b8mazw6