Skip to content

Fix | Remove incorrectly added functions when creating OpenAPI documentation#507

Merged
smarcet merged 1 commit intomainfrom
fix/error-creating-flag-list
Feb 24, 2026
Merged

Fix | Remove incorrectly added functions when creating OpenAPI documentation#507
smarcet merged 1 commit intomainfrom
fix/error-creating-flag-list

Conversation

@matiasperrone-exo
Copy link
Contributor

@matiasperrone-exo matiasperrone-exo commented Feb 23, 2026

@matiasperrone-exo matiasperrone-exo self-assigned this Feb 23, 2026
@matiasperrone-exo matiasperrone-exo added documentation Improvements or additions to documentation bug Something isn't working labels Feb 23, 2026
@matiasperrone-exo matiasperrone-exo force-pushed the fix/error-creating-flag-list branch from 7865e49 to fa687c2 Compare February 23, 2026 21:16
Copy link
Contributor

@martinquiroga-exo martinquiroga-exo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matiasperrone-exo this is unclean, either revert the entire PR so no documentation code is present, since only removing the culprit methods will leave swagger headless, or override them correctly so they get picked up:

use AddSummitChildElement {
    add as private traitAdd;
}

#[OA\Post(...)]
public function add($summit_id)
{
    return $this->traitAdd($summit_id);
}

I defer to @smarcet on which one fits best in this case.

@smarcet
Copy link
Collaborator

smarcet commented Feb 24, 2026

@martinquiroga-exo please follow this pattern swagger framework pick up the documentation automatically

Copy link
Collaborator

@smarcet smarcet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM its follows the approved pattern

@smarcet smarcet merged commit 366a325 into main Feb 24, 2026
20 checks passed
@martinquiroga-exo
Copy link
Contributor

Just realised the "From trait" comment. Great then. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants