Feature/refresh login signup by LucHeart · Pull Request #155 · OpenShock/Frontend

LucHeart · 2026-02-09T09:16:32Z

No description provided.

changeset-bot · 2026-02-09T09:16:37Z

⚠️ No Changeset found

Latest commit: e2daa07

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6b5d2cc9f0

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

src/lib/api/internal/v1/apis/AccountApi.ts

src/lib/components/auth/oauth-buttons.svelte

src/lib/api/internal/v1/apis/AccountApi.ts

src/lib/components/auth/login-form.svelte

src/lib/components/auth/signup-form.svelte

src/lib/components/svg/GithubIcon.svelte

src/lib/components/Turnstile.svelte

cloudflare-workers-and-pages · 2026-02-09T12:39:59Z

Deploying openshockapp with Cloudflare Pages

Latest commit:	`e2daa07`
Status:	✅ Deploy successful!
Preview URL:	https://686c3f08.openshockapp.pages.dev
Branch Preview URL:	https://feature-refresh-login-signup.openshockapp.pages.dev

View logs

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

…gin-signup

Copilot

Pull request overview

Copilot reviewed 27 out of 28 changed files in this pull request and generated 10 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

src/routes/Footer.svelte

Copilot · 2026-02-17T01:56:11Z

src/routes/(anonymous)/login/+page.svelte

-    usernameOrEmail.length > 0 && password.length > 0 && turnstileResponse != null
-  );
+  import LoginForm from '$lib/components/auth/login-form.svelte';
+  import { asset, resolve } from '$app/paths';


resolve is imported but never used in this page. Please remove the unused import to avoid lint/TS warnings.

Suggested change

import { asset, resolve } from '$app/paths';

import { asset } from '$app/paths';

Copilot · 2026-02-17T01:56:12Z

src/lib/components/svg/GithubIcon.svelte

+<svg
+  role="img"
+  viewBox="0 0 24 24"
+  fill="none"
+  xmlns="http://www.w3.org/2000/svg"
+  class={className}
+>


This SVG has role="img" but no accessible name (no aria-label and no <title>). Please add aria-label="GitHub" (or restore a <title>GitHub</title>) so screen readers can announce it correctly, or mark it aria-hidden="true" if it’s purely decorative.

src/lib/components/auth/login-form.svelte

Copilot · 2026-02-17T01:56:12Z

src/lib/components/auth/login-form.svelte

+    By clicking continue, you agree to our <a href="https://openshock.org/tos" target="_blank"
+      >Terms of Service</a
+    >
+    and <a href="https://openshock.org/privacy" target="_blank">Privacy Policy</a>.


These external links open in a new tab (target="_blank") but don’t include rel="noopener noreferrer". Add it to prevent reverse-tabnabbing.

Suggested change

By clicking continue, you agree to our <a href="https://openshock.org/tos" target="_blank"

>Terms of Service</a

>

and <a href="https://openshock.org/privacy" target="_blank">Privacy Policy</a>.

By clicking continue, you agree to our <a href="https://openshock.org/tos" target="_blank" rel="noopener noreferrer"

>Terms of Service</a

>

and <a href="https://openshock.org/privacy" target="_blank" rel="noopener noreferrer">Privacy Policy</a>.

Copilot · 2026-02-17T01:56:12Z

src/routes/Footer.svelte


-<footer class="bottom-0 flex flex-none items-center justify-between px-2 text-sm">
+<footer
+  class="text-muted-foreground text-sm-foreground bottom-0 flex flex-none items-center justify-between px-2"


The footer class list contains text-sm-foreground, which isn’t a valid Tailwind utility (likely meant text-sm). This will be ignored at runtime and may hide intended styling—please correct/remove the invalid class name.

Suggested change

class="text-muted-foreground text-sm-foreground bottom-0 flex flex-none items-center justify-between px-2"

class="text-muted-foreground text-sm bottom-0 flex flex-none items-center justify-between px-2"

Copilot · 2026-02-17T01:56:13Z

src/lib/components/input/TextInput.svelte

+    FieldGroup,
+    Field,
+    FieldLabel,
+    FieldDescription,
+    FieldSeparator,


These imports from the field UI module are unused (FieldGroup, FieldDescription, FieldSeparator). Please remove them to avoid lint/TS warnings and keep the component minimal.

Suggested change

FieldGroup,

Field,

FieldLabel,

FieldDescription,

FieldSeparator,

Field,

FieldLabel,

src/lib/components/auth/signup-form.svelte

src/lib/components/auth/login-form.svelte

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

src/routes/(anonymous)/login/+page.svelte

LucHeart added 5 commits February 9, 2026 02:12

rework login form

939d479

add logo

61f709e

reworked the footer, woops

0c2dbb1

Signup rework

d29fd57

dynamic display of oauth providers

6b5d2cc

Copilot AI review requested due to automatic review settings February 9, 2026 09:16

LucHeart requested review from hhvrc and removed request for Copilot February 9, 2026 09:16

Copilot started reviewing on behalf of LucHeart February 9, 2026 09:16 View session

chatgpt-codex-connector bot reviewed Feb 9, 2026

View reviewed changes

src/lib/api/internal/v1/apis/AccountApi.ts Outdated Show resolved Hide resolved

src/lib/components/auth/oauth-buttons.svelte Outdated Show resolved Hide resolved

hhvrc reviewed Feb 9, 2026

View reviewed changes

hhvrc added 2 commits February 9, 2026 13:31

Merge branch 'develop' into feature/refresh-login-signup

f10f13d

Apply backend metadata store change and fix generated OpenAPI client

7465cb1

Copilot AI review requested due to automatic review settings February 9, 2026 12:39

Copilot AI reviewed Feb 9, 2026

View reviewed changes

Merge remote-tracking branch 'origin/develop' into feature/refresh-lo…

09bd2d6

…gin-signup

hhvrc requested a review from Copilot February 17, 2026 01:48

Copilot started reviewing on behalf of hhvrc February 17, 2026 01:48 View session

Copilot AI reviewed Feb 17, 2026

View reviewed changes

LucHeart and others added 9 commits February 17, 2026 10:14

Update src/lib/components/auth/login-form.svelte

67bc5ec

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update src/routes/Footer.svelte

ce753d9

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update src/lib/components/auth/signup-form.svelte

aceaa22

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

move signup using email behind button

f99792c

Merge branch 'develop' into feature/refresh-login-signup

bff7d98

fix eslint errors

5a101b2

ignore the shit error

e8d8cd3

run build always...

0e99e16

fix double runs

f53ef1f

ignore errors

e2daa07

hhvrc approved these changes Feb 18, 2026

View reviewed changes

src/routes/(anonymous)/login/+page.svelte Show resolved Hide resolved

LucHeart merged commit 473746b into develop Feb 18, 2026
11 checks passed

LucHeart deleted the feature/refresh-login-signup branch February 18, 2026 14:00

	import { asset, resolve } from '$app/paths';
	import { asset } from '$app/paths';

	class="text-muted-foreground text-sm-foreground bottom-0 flex flex-none items-center justify-between px-2"
	class="text-muted-foreground text-sm bottom-0 flex flex-none items-center justify-between px-2"

Conversation

LucHeart commented Feb 9, 2026

Uh oh!

changeset-bot bot commented Feb 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cloudflare-workers-and-pages bot commented Feb 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Deploying openshockapp with Cloudflare Pages

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI Feb 17, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 17, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI Feb 17, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 17, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 17, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Comments

changeset-bot bot commented Feb 9, 2026 •

edited

Loading

cloudflare-workers-and-pages bot commented Feb 9, 2026 •

edited

Loading