fix: always fetch manifest from GitHub, cache is offline-only#3271
Closed
AhmedTMM wants to merge 1 commit intoOpenRouterTeam:mainfrom
Closed
fix: always fetch manifest from GitHub, cache is offline-only#3271AhmedTMM wants to merge 1 commit intoOpenRouterTeam:mainfrom
AhmedTMM wants to merge 1 commit intoOpenRouterTeam:mainfrom
Conversation
The manifest cache (1h TTL) could get stuck stale if fetches failed silently, hiding new agents/clouds for days. Now the CLI always fetches fresh from GitHub on every run — cache is only used as an offline fallback when the network is unreachable. Removed CACHE_TTL and tryLoadFromDiskCache since the cache-first path is no longer used. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
3 tasks
Collaborator
Author
|
Superseded by #3272 — same approach but with 3s timeout instead of 10s for bad wifi. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CACHE_TTLandtryLoadFromDiskCache— no more cache-first pathWhy
The 1h cache TTL could get stuck stale if GitHub fetches failed silently. Users would see a 14-day-old manifest missing new agents/clouds (like Daytona and Pi) with no way to fix it except manually deleting the cache file.
Trade-off
Each
spawnrun now makes a ~10KB network request to GitHub. The 10s timeout ensures it doesn't block if GitHub is slow. For users who run spawn frequently, the in-memory cache still works within the same process.Test plan
🤖 Generated with Claude Code