SAWE standard applied to GASP mass buildup#1065
SAWE standard applied to GASP mass buildup#1065jkirk5 wants to merge 22 commits intoOpenMDAO:mainfrom
Conversation
…to mass_buildup
| expected_values = { | ||
| Aircraft.Propulsion.TOTAL_ENGINE_MASS: 23405.94, | ||
| Aircraft.Propulsion.TOTAL_ENGINE_POD_MASS: 8074.09809932, | ||
| # Aircraft.Propulsion.TOTAL_ENGINE_POD_MASS: 8074.09809932, |
There was a problem hiding this comment.
We no longer need to keep track of pod mass?
There was a problem hiding this comment.
No longer an output of this component (it's a summation of other masses, which I have moved into separate components to allow for overriding of individual masses)
| promotes_outputs=['*'], | ||
| ) | ||
|
|
||
| newton = self.nonlinear_solver = om.NewtonSolver() |
There was a problem hiding this comment.
There didn't used to be a solver on this subsystem, why are we adding one now?
Did you remove a solver on some other subsystem?
There was a problem hiding this comment.
Yeah, there used to be a solver in the "fuel" group (which actually calculated fuel tanks, fuselage mass, propulsion mass, structure mass, and operating empty mass). I broke that group up, so the solver moves up to here
| * foo | ||
| * wingspan_mod**1.049 | ||
| * (1.0 + taper_ratio) ** 0.4 | ||
| ) / (100000.0 * tc_ratio_root**0.4 * np.cos(half_sweep) ** 1.535) + high_lift_wt |
There was a problem hiding this comment.
we were doing all these calculations and we didn't even use them! wow.
There was a problem hiding this comment.
I bet someone just copy/pasted the entire compute in here and never trimmed it down to what was actually needed
3 participants
Summary
Reworked GASP's mass buildup to conform to SAWE standard, unifying how mass buildups are reported in GASP & FLOPS.
Some additional detangling of GASP's components, which is incomplete (but outside the scope of this PR)
Related Issues
Backwards incompatibilities
None
New Dependencies
None