Conversation
|
This is on top of #896 - only the top 3 patches are related to PPS. I am looking for feedback if this is the direction to go to support the other capability described in #856 . User can do these things now: NOTE: ignore all the duplicated code, I needed something quick that I can test. I will be creating tests for the current capability - I tried only very simple things. |
|
quick and likely silly quesiton: why an initilaizer() function? can we execute multiple times a PP? |
Currently the only reason is to match the API pattern in things like
Yes. However, I do not have any API that would change the class so that |
b472efb to
0205b30
Compare
c6e0424 to
1b876a6
Compare
modules/linear_boltzmann_solvers/lbs_problem/postprocessors/volume_postprocessor.cc
Outdated
Show resolved
Hide resolved
modules/linear_boltzmann_solvers/lbs_problem/postprocessors/volume_postprocessor.cc
Show resolved
Hide resolved
|
This looks good, but I don't see support for the optional multiplier. Did I miss that? |
I concur with Daryl. Earlier today, I was wondering how to compute reaction rates. Here's the blurb from the issue. The Multiplier / responseSupported types (v1)
XS sources
Material dependence ruleIf the multiplier is material-dependent, it is evaluated using each selected cell’s material ID: |
|
My understanding was that @kitamuraa24 was assigned to implemented this and he has some code for that as far as I am aware. But I have not seen that, so IDK in which state that is. |
I knew he was working on a solution for his project, but I didn't realize it was intended to supplement the vpp work. |
|
Hi, I have some stuff here with a unit test based off the reed problem; but it does not test multigroup fluxes or the block_id filtering. I have tested for the block_id, but I have not yet tested the multigroup fluxes yet. Here is my branch: features/reaction_rates. The implementation here is based off utilizing field functions. |
|
@andrsd (cc @wdhawkins ) I think you should add the multiplier. Can you do this today? Tomorrow, Daryl and I have a session planned to use the VPP for sensitivity and we'd like to base it on the VPP and would prefer to branch out from main instead of from this PR. |
I should be able to get it in today. |
d1b4736 to
cd0aea0
Compare
So, it can be reused by other tests if needed
Ref #856