Remove multigroup_xs_stack from runtime.#1015
Merged
wdhawkins merged 1 commit intoOpen-Sn:mainfrom Apr 6, 2026
Merged
Conversation
ragusa
reviewed
Apr 5, 2026
Contributor
ragusa
left a comment
ragusa
left a comment
There was a problem hiding this comment.
What was the purpose of having it on the stack? What are the consequences of removing it?
Collaborator
Author
This is legacy code from the Lua days. It serves no purpose now other than it prevents us from managing our object lifetimes entirely from Python. |
ragusa
approved these changes
Apr 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.