Numerous bug fixes for field function and interpolation routines#1014
Merged
wdhawkins merged 1 commit intoOpen-Sn:mainfrom Apr 6, 2026
Merged
Numerous bug fixes for field function and interpolation routines#1014wdhawkins merged 1 commit intoOpen-Sn:mainfrom
wdhawkins merged 1 commit intoOpen-Sn:mainfrom
Conversation
ragusa
approved these changes
Apr 5, 2026
andrsd
approved these changes
Apr 6, 2026
…luding: 1. Removing unused global field function and interpolation volume stacks from runtime. 2. Removing unused field function routines GetFieldFunctions and GetFieldFunctionsByName. 3. Made interpolation explicity single ff (previously it stored a vector of ff but only used front). 4. Removed intepolation Initialize routine. Execute now calls Initialize so internal state is always consistent. 5. GetPointValue now throws if no cell containing the specified point is found. 6. Fixed MPI reduction for GetPointValue to correctly handle multi-component field functions. 7. Fixed line and volume interpolators to account for empty local contributions. 8. Fixed line and volume interpolators to clear cached state. 9. Validate line interpolation with fewer than 2 points. 10. Fixed line interpolation so that points on shared boundaries are not double counted. 11. Adding SetPointOfInterest to Python API so that point ff is usable. 12. Updated Python API documentation. 13. Updated regression tests to remove deprecated Initialize method.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes the following fixes and updates: