Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4ff9896bfd
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
src/config/edit.rs
Outdated
| doc["rewrite"]["policy_path"] = toml_edit::value(crate::agentic_rewrite::default_policy_path()); | ||
| doc["rewrite"]["glossary_path"] = | ||
| toml_edit::value(crate::agentic_rewrite::default_glossary_path()); | ||
| doc["agentic_rewrite"]["default_correction_policy"] = | ||
| doc["rewrite"]["default_correction_policy"] = | ||
| toml_edit::value(RewriteCorrectionPolicy::Balanced.as_str()); |
There was a problem hiding this comment.
Preserve rewrite policy settings when selecting a model
Avoid resetting rewrite.policy_path, rewrite.glossary_path, and rewrite.default_correction_policy in update_config_rewrite_selection. After this release, those fields are part of the active unified rewrite mode, so running whispers rewrite-model select ... now silently overwrites user custom policy/glossary locations and correction policy (e.g., conservative/aggressive) just to change models, which can disable expected rewrite behavior.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Fixed in a follow-up commit on this PR branch. update_config_rewrite_selection() now preserves rewrite.policy_path, rewrite.glossary_path, and rewrite.default_correction_policy, and I added a regression test covering custom policy/glossary locations plus a non-default correction policy.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e4e437967f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| recent_entries: vec![to_rewrite_session_entry(&recent_entry.entry)], | ||
| candidates: vec![replace_candidate.clone(), append_candidate], | ||
| recommended: Some(replace_candidate), | ||
| deterministic_replacement_text: preferred_current_text_for_exact_followup(transcript), | ||
| } |
There was a problem hiding this comment.
Restore deterministic replacement for follow-up alias cues
Removing the deterministic replacement from SessionBacktrackPlan drops the only path that converted explicit follow-up aliases into clean replacement text (for example srajvat, hi / scratchfarts, hi, which cleanup::explicit_followup_replacement still recognizes). build_backtrack_plan can still recommend ReplaceLastEntry for these utterances, but without the precomputed replacement it falls back to correction_aware_text/raw text, so when rewrite is unavailable (or falls back) the prior entry is replaced with the literal cue phrase instead of the intended tail like hi.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Fixed in a follow-up commit on this PR branch. Explicit follow-up aliases now feed the session replace candidate text again, and the rewrite fallback path reuses that deterministic tail when a replace-last-entry session action is active. I also added regression tests covering the alias fallback path and the rewrite-plan fallback text.
Summary
rewritemode with backward-compatible config aliasesmy apologies, I meant ...to LLM adjudication instead of deterministic replacementwhispers voicecommand0.2.1Release Notes
Added
[agentic_rewrite]config fieldsChanged
rewrite[rewrite]Fixed
my apologies, I meant ...no longer get over-filtered by deterministic correction handlingwhispers voicecommandVerification
cargo test --quietcargo publish --dry-run --locked0.2.1Notes
release-0.2.0PR.