Prepare 0.3.0 release and split Linux/macOS distribution paths#2
Prepare 0.3.0 release and split Linux/macOS distribution paths#2
Conversation
03d50fd to
e2d8d01
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1150e75320
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| match env::consts::ARCH { | ||
| "x86_64" => Ok("x86_64-unknown-linux-gnu"), |
There was a problem hiding this comment.
Guard launcher target triple against musl builds
current_target_triple() hardcodes every x86_64 Linux build to x86_64-unknown-linux-gnu, while the compile-time gate only checks target_os/target_arch. That means cargo install taskers still succeeds on x86_64-unknown-linux-musl systems (e.g., Alpine), but the launcher then downloads the glibc bundle and fails when executing bin/taskers due to missing glibc loader support. Please reject non-gnu targets (for example with target_env = "gnu") or resolve artifacts from the full target triple.
Useful? React with 👍 / 👎.
Summary
taskerslauncher while macOS ships from GitHub Releases DMGs0.3.0and update the release checklist for the new publish order and Cargo dry-run behaviorValidation
cargo testcargo check --workspacebash scripts/smoke_taskers_ui.shbash scripts/smoke_taskers_focus_churn.shbash scripts/build_linux_bundle.shbash scripts/smoke_linux_release_launcher.shcargo publish --dry-run -p taskers-domaincargo publish --dry-run -p taskers-pathscargo install --offline --path crates/taskers-appNotes