Feature/cmake hip spirv clean

[sriasapu]

Summary

• CMake support for HIP-only builds, optional HIP + SPIR-V (amdgcnspirv-style offload), and skip lists (string + optional file).
• Default full-stack behavior is unchanged when all HECBENCH_ENABLE_* options stay ON and skip lists are empty.
• No CMake-time editing of benchmark Makefiles (CMake targets do not use them).

Motivation

• Integrators (superbuilds, CI) need HIP-only trees and SPIR-V compile/link flags without conflicting per-target gfx HIP_ARCHITECTURES / --offload-arch=${HECBENCH_HIP_ARCH}.
• Skip lists are easier to maintain in a file (one benchmark id per line) than in one long cache string.

Changes

CMakeLists.txt

• HECBENCH_ENABLE_HIP_ONLY — HIP-only discovery; warns if other model cache vars still look enabled.
• HECBENCH_ENABLE_SPIRV, HECBENCH_SPIRV_TARGET — SPIR-V mode; default HECBENCH_HIP_EXTRA_CFLAGS / HECBENCH_HIP_LDFLAGS when unset.
• HECBENCH_HIP_EXTRA_CFLAGS, HECBENCH_HIP_LDFLAGS — global HIP compile/link options (HIP language only).
• CMAKE_HIP_ARCHITECTURES — HECBENCH_SPIRV_TARGET if SPIR-V, else HECBENCH_HIP_ARCH.
• HECBENCH_SKIP_BENCHMARKS, HECBENCH_SKIP_BENCHMARKS_FILE — merged skip list with # comments in the file.
• check_language(HIP) / enable_language(HIP) when HIP is on but the HIP compiler was not set at first project().
• find_package(OpenMP REQUIRED) — drop dead else after REQUIRED.
• Extended configure status output for HIP / SPIR-V / extras.

src/CMakeLists.txt

• add_subdirectory only if the benchmark’s model matches an enabled HECBENCH_ENABLE_*.
• Skip list parsing + merge from HECBENCH_SKIP_BENCHMARKS_FILE.

cmake/modules/BenchmarkMacros.cmake

• SPIR-V: omit per-target gfx HIP_ARCHITECTURES and --offload-arch=${HECBENCH_HIP_ARCH}; add -Wno-#warnings for HIP only.

Example

cmake -S . -B build \
  -DHECBENCH_ENABLE_HIP_ONLY=ON \
  -DHECBENCH_ENABLE_SPIRV=ON \
  -DCMAKE_HIP_COMPILER=/path/to/clang++ \
  -DHECBENCH_HIP_ARCH=gfx942
cmake --build build

[marbre]

I am not familiar with HeCBench but I see several major issues here. Leaving some comments as I was asked to but it requires a more careful evaluation of those familiar with the project.

In addition to my other comments my main concern is about Makefile patching. Each benchmark is added via add_subdirectory and has it's own CMakeLists.txt. CMake generates a proper target and never invokes the manually written Makefile. Thus patching those Makefiles accomplished nothing for the CMake build as Makefiles get generated via CMake (if not using Ninja).

I think you rather want to use the CMake based build and there may be adjustments needed, but the Makefile patching isn't part of this.

[marbre]

I still don't see the motivation for this. If a user does not want to build all targets they can simply skip passing --target all. What you instead want might be a custom target. This could be created from a positive list instead. However, I would propose to avoid the regex approach.

[marbre]

If HIP is enabled, and the below message states this, you don't want to silently fail on find_package(HIP) do you?

[marbre]

Why is this dropped? This seems unrelated to your PR thus I'd suggest to not touch it.

[marbre]

Why not adding HIP conditionally to LANGUAGES e.g. via project(LANGUAGES C CXX ${HIP_OPTIONAL}?