Merged
Conversation
`pkg_config` automaticially links against libwebp when we probe it. libwebp is already probed if `generate-bindings` (in `include_paths`), but we need to manually probe if `generate-bindings` is disabled.
abezukor
force-pushed
the
fix_dyanmic_link
branch
from
66c8027 to
8208ecf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the current
build.rsif thesystem-dylibfeature is enabled, the static library is still compiled. Additionally ifgenerate-bindingsis enabled it will generate against the vendored headers, not the system headers.