Skip to content

Goddess bills implementation (custom NPC)#350

Open
kenedos wants to merge 1 commit intoNoCode-NoLife:masterfrom
kenedos:goddess_bills
Open

Goddess bills implementation (custom NPC)#350
kenedos wants to merge 1 commit intoNoCode-NoLife:masterfrom
kenedos:goddess_bills

Conversation

@kenedos
Copy link
Contributor

@kenedos kenedos commented Nov 13, 2025

What this PR Does:

  • Adds a new NPC that allows players to exchange their silver for "bill" items.
  • Bills can be also converted back to silver in the same NPC.
  • With this, players are able to indirectly trade silver with eachother (by exchanging bills, as silver is not normally tradeable).
  • In addition to this, this PR includes IES Mods to set the bill item descriptions (optional in items.conf file).
  • NPC and conf file option are disabled by default.

What this PR does NOT implement:

  • Trading between players

@exectails
Copy link
Member

This seems familiar, didn't we already have this at some point?^^ Anyway, I wonder if you considered the option of modifying trading to add silver trading. Wouldn't that be more straight forward than going this route?

@kenedos
Copy link
Contributor Author

kenedos commented Mar 19, 2026

I do have a vague memory of us discussing it and you showing an implementation but for some reason I was unable to find it in Melia.

Direct silver trading is also a possibility, probably an even better one, but silver exchanging is prohibited in most systems in this game, not just trading. You're not able to send silver via mail for example, or put silver in guild storage, etc. This NPC is very 'gimmicky' and I do agree it's very niche usage. Even in Laima, I don't think anyone ever traded goddess bills or needed to trade silver directly as there's buy/sellshops and for the original game there's the marketplace (auction house).

It's up to you, if you feel this NPC is too weird to be in base Melia that's fine. I do feel it's in very similar scope to what eA normally has with custom NPCs though - stylist, warper, pvp arena, etc.

@SalmanTKhan
Copy link
Contributor

Just to chime in, might've been in the Melia "1.0" with Lua scripts.

@exectails
Copy link
Member

I do feel it's in very similar scope to what eA normally has with custom NPCs though - stylist, warper, pvp arena, etc.

Absolutely, I didn't mean to imply that I'm opposed to custom NPCs like this. Even if we did add direct silver trading, there could be some purpose for this functionality. Though I'd prefer if everything was moved to scripts, so it doesn't require conf and core changes. The script can set up the IES mods as well and then you'd just have to enable the script to enable it all, right?

might've been in the Melia "1.0" with Lua scripts

Yea, probably^^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants