Open
Conversation
added 2 commits
April 29, 2022 16:58
yashwantdhakad
approved these changes
May 2, 2022
yashwantdhakad
left a comment
yashwantdhakad
left a comment
There was a problem hiding this comment.
Changes look good added a few minor suggestions.
|
|
||
| import java.util.Scanner; | ||
|
|
||
| class calculator { |
There was a problem hiding this comment.
Class name should be in the upper camel case
| class calculator { | ||
|
|
||
| void circle() { | ||
| System.out.println("Please Enter Radious"); |
There was a problem hiding this comment.
Can you please handle the exception if the number value is not in the correct format?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.