SCHOL-314: Re-enable and update pdf tests#191
Merged
jackiequach merged 3 commits intoSCHOL-305/implement-designsfrom Feb 18, 2026
Merged
SCHOL-314: Re-enable and update pdf tests#191jackiequach merged 3 commits intoSCHOL-305/implement-designsfrom
jackiequach merged 3 commits intoSCHOL-305/implement-designsfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
alea12
reviewed
Feb 13, 2026
jackiequach
merged commit 336675f
into
SCHOL-305/implement-designs
4 of 6 checks passed
jackiequach
added a commit
that referenced
this pull request
Feb 18, 2026
* initial design changes * update html settings * implement reset settings and current page for PDFs * add fit to height and width functionality for pdf * implement fit to height/width for HTMLReader * fix flickering on pdf reader * add tooltips * fix scrolling fit to height zoom issue * add rotate left functionality * address comment, update epub settings menu and icon sizes * fix chapter nav * implement full screen * update and remove tests * update unit tests * fix scaling issue * update playwright test to run against localhost * remove console log and fix flickering issue * SCHOL-314: Re-enable and update pdf tests (#191) * re-enable pdf tests and add test for page input * fix flaky locator * address comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SCHOL-314
Base branch is the design implementation branch for UI changes.